Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❎ Removes dotenv override #72

Merged
merged 1 commit into from
Jul 6, 2023
Merged

❎ Removes dotenv override #72

merged 1 commit into from
Jul 6, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jul 5, 2023

dotenv override

Removes override for dotenv config

  • ENV_VARIABLES should override dotenv config
  • Production instance should be able to set variable without creating an .env.PRODUCTION file

@mrharpo mrharpo added the production 🎭 Relating to the production deployment label Jul 5, 2023
@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone Jul 5, 2023
@mrharpo mrharpo requested a review from afred July 5, 2023 22:31
@mrharpo mrharpo self-assigned this Jul 5, 2023
@mrharpo mrharpo temporarily deployed to Codecov July 5, 2023 22:31 — with GitHub Actions Inactive
afred
afred approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 9115917 into main Jul 6, 2023
8 checks passed
@afred afred deleted the env-override branch July 6, 2023 15:56
mrharpo added a commit that referenced this pull request Jul 6, 2023
@mrharpo
Merge branch 'main' into docs
087e109 
* main:
  Removes dotenv override (#72)
  🤖 Update dependencies (#61)
  👣 Migration tool (#62)
  Adds on: workflow_dispatch to all actions (#63)
  Updates another workflow pointer (#60)
mrharpo added a commit that referenced this pull request Jul 7, 2023
@mrharpo
Merge branch 'docs' into metaflow-ingest
4eb4ad2 
* docs:
  Removes old note
  Fixes DB_NAME env
  Fixes lint errors
  Changes SonyCiAsset.id to int
  🐋 Dockerfile migrations (#77)
  💽 `postgresql://` in all environments (#73)
  Removes dotenv override (#72)
  🤖 Update dependencies (#61)
  👣 Migration tool (#62)
  Adds on: workflow_dispatch to all actions (#63)
  Updates another workflow pointer (#60)
  ☝️ Updates workflow pointer (#59)
  Sets chowda db name for CI to 'chowda'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
production 🎭 Relating to the production deployment
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.3.0 Pipeline 🚰
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @afred